Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PVO2EM audio.c build error: "Undeclared function ext_IRQ()." #2234

Closed
urherenow opened this issue Sep 26, 2023 · 5 comments
Closed

[Bug] PVO2EM audio.c build error: "Undeclared function ext_IRQ()." #2234

urherenow opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
audio sound or music related bug something broken that needs fixing, confirmed and reproduceable build error errors that break the build can't reproduce …meaning good chance it will have a short life as an open issue requires feedback pending unanswered question
Milestone

Comments

@urherenow
Copy link
Contributor

urherenow commented Sep 26, 2023

When building Provenance-XL, it errors on PVO2EM audio.c. Undeclared function ext_IRQ(). ISO 99 and later do not support implicit...

Expected:

Build without errors

Actual:

XCODE halted building on this error.

Reproduce:

  1. Clone repo
  2. Setup code signing and remove necessary things like app groups
  3. Choose Provenance-XL scheme
  4. Try to build

APP VERSION

Latest Git

APP SOURCE

Provenance-Emu GitHub

INSTALLED BY

Building

PLATFORM

iOS/iPAD

iOS/tvOS VERSION

16.6.1

🚫 We DO NOT support unofficial builds installed from 3rd-party sites. (Official Install)
Need help or have a suggestion? Join our Official Discord

@urherenow urherenow added the bug something broken that needs fixing, confirmed and reproduceable label Sep 26, 2023
@issuelabeler issuelabeler bot added the audio sound or music related label Sep 26, 2023
@robkoehler45
Copy link

robkoehler45 commented Dec 19, 2023

I also run into this trying to build to Apple TV/tvOS. 17.2, xCode 15.1. iOS build works fine to iPhone 14 Pro.

@JoeMatt JoeMatt self-assigned this Jan 10, 2024
@JoeMatt
Copy link
Member

JoeMatt commented Jan 10, 2024

Can you check on current develop branch.

CI and local builds are working for me on this at the moment.

@JoeMatt JoeMatt added can't reproduce …meaning good chance it will have a short life as an open issue requires feedback pending unanswered question labels Jan 10, 2024
@JoeMatt JoeMatt added this to the 2.3.0 milestone Jan 10, 2024
@JoeMatt JoeMatt changed the title PVO2EM audio.c Bug Report [Bug] PVO2EM audio.c build error: "Undeclared function ext_IRQ()." Jan 10, 2024
@issuelabeler issuelabeler bot added the build error errors that break the build label Jan 10, 2024
@JoeMatt
Copy link
Member

JoeMatt commented Jan 11, 2024

Nevermind, I found the issue.

had to extern ext_IRQ since we don't import the header it's declared in due to other issues. The symbol is there just needed the signiture.

JoeMatt added a commit that referenced this issue Jan 11, 2024
Signed-off-by: Joseph Mattello <[email protected]>
@urherenow
Copy link
Contributor Author

My apologies. I live on Japan time, so I only just now have time to try a fresh build. Deleted my derived data and making a fresh clone to give it a try. This might take a while...

@urherenow
Copy link
Contributor Author

urherenow commented Jan 11, 2024

Sigh... didn't work, because it isn't merged into develop. tried to checkout [feature/XCode15BetaMiscFixes] but now it has all kinds of bundle identifier issues, like CodeSigning.xcconfig isn't being used, and I get app group types of errors, even though I've already removed the app group stuff from entitlements.

I'll just wait until everything is merged to develop, then I'll tray again from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio sound or music related bug something broken that needs fixing, confirmed and reproduceable build error errors that break the build can't reproduce …meaning good chance it will have a short life as an open issue requires feedback pending unanswered question
Projects
None yet
Development

No branches or pull requests

3 participants