Game Importer Fixes for cloud and local files

[proskd]

User description

What does this PR do

Generally, this PR should ensure that upon first successful launch, the app will be in a state to properly accept imports from cloud and local files sources.

1. Fixes setup of database and caches at first launch
2. Fixes case where the file being accessed isn't a secure file (and doesn't need to be accessed as such)

Where should the reviewer start

How should this be manually tested

1. Clean launch of the app
2. import any valid ROM
3. Observe

After imports are processed, the library should be updated properly with the ROMs selected.

Cases I tested:

1. Single ROM
2. Multiple ROM selection
3. BIOS selection
4. CD ROM zip file

Any background context you want to provide

What are the relevant tickets

Screenshots (important for UI changes)

Questions

---

PR Type

enhancement, bug_fix

---

Description

• Enhanced RomDatabase with async cache management methods and synchronous access options.
• Improved directory setup in GameImporter to ensure necessary directories are created.
• Fixed potential issues with security-scoped resource access in PVRootViewController.
• Updated various components to use synchronous cache access where appropriate for performance and reliability.

---

Changes walkthrough 📝

	Relevant files
Enhancement	PVEmulatorConfiguration+Frameworks.swift Update database refresh and BIOS addition logic                    PVLibrary/Sources/PVLibrary/Configuration/PVEmulatorConfiguration+Frameworks.swift Changed RomDatabase method call from refresh to reloadCache. Updated database.add to avoid conflicts with duplicate BIOS names. +4/-2      PVEmulatorConfiguration.swift Use synchronous system cache access                                            PVLibrary/Sources/PVLibrary/Configuration/PVEmulatorConfiguration.swift Replaced getSystemCache with getSystemCacheSync for synchronous access. +1/-1      RomDatabase+Caches.swift Implement async cache management in RomDatabase                    PVLibrary/Sources/PVLibrary/Database/Realm Database/RomDatabase+Caches.swift Introduced async versions of cache reload methods. Added synchronous cache retrieval methods. Updated cache reload logic to use async tasks. +50/-27  PVGame+Paths.swift Use synchronous system cache access in PVGame                        PVLibrary/Sources/PVLibrary/Game Media/PVGame+Paths.swift Updated method to use synchronous system cache access. +1/-1      GameImporter.swift Refactor GameImporter directory setup and cache access      PVLibrary/Sources/PVLibrary/Importer/Services/GameImporter/GameImporter.swift Added biosPath property for BIOS directory management. Refactored directory creation logic into a separate method. Updated cache access to use synchronous methods where necessary. +31/-24  PVGameLibraryViewController.swift Use synchronous BIOS cache access in Game Library                PVUI/Sources/PVUIBase/Game Library/CollectionViewController/PVGameLibraryViewController.swift Switched to synchronous BIOS cache access. +1/-1      PVGameLibraryUpdatesController.swift Use async cache retrieval in Game Library Updates                PVUI/Sources/PVUIBase/Game Library/PVGameLibraryUpdatesController.swift Updated to use async cache retrieval for games and systems. +3/-3
Bug fix	PVRootViewController.swift Improve security-scoped resource handling                                PVUI/Sources/PVSwiftUI/RootView/PVRootViewController.swift Added logic to handle security-scoped resource access. +8/-6

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential Race Condition The reloadCache() method now uses a detached task to reload caches asynchronously. This could potentially lead to race conditions if other parts of the code access the cache while it's being reloaded. Error Handling The createDefaultDirectory method catches errors but only logs them. Consider whether more robust error handling or recovery is needed. Resource Management The stopAccessingSecurityScopedResource() is now conditionally called. Ensure this doesn't lead to resource leaks if securityScoped is incorrectly set.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Implement proper error handling for asynchronous operations Consider using a more robust error handling mechanism instead of force unwrapping with try! to improve the stability of the code. PVLibrary/Sources/PVLibrary/Database/Realm Database/RomDatabase+Caches.swift [34-36] Task.detached { @MainActor in - await self.reloadCaches() + do { + try await self.reloadCaches() + } catch { + ELOG("Failed to reload caches: \(error)") + } } Apply this suggestion Suggestion importance[1-10]: 8 Why: This suggestion enhances the stability of the code by adding error handling for asynchronous operations, which is crucial for maintaining robust and reliable software.	8
	Implement proper error handling for database operations Consider using a more robust error handling mechanism instead of force unwrapping with try! to improve the stability of the code. PVLibrary/Sources/PVLibrary/Importer/Services/GameImporter/GameImporter.swift [176] -try! database.add(newBIOS, update: true) +do { + try database.add(newBIOS, update: true) +} catch { + ELOG("Failed to add BIOS: \(error)") +} Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion to replace force unwrapping with proper error handling significantly improves the code's stability and reliability, making it a valuable enhancement.	8
	Use more descriptive variable names to improve code clarity Consider using a more descriptive variable name instead of database to improve code readability and maintainability. PVLibrary/Sources/PVLibrary/Configuration/PVEmulatorConfiguration+Frameworks.swift [174-176] -database.refresh() +romDatabase.refresh() //avoids conflicts if two BIOS share the same name - looking at you jagboot.rom -try! database.add(newBIOS, update: true) +try! romDatabase.add(newBIOS, update: true) Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion to use a more descriptive variable name like 'romDatabase' instead of 'database' can improve code readability and maintainability. However, the impact is moderate as it does not address any functional issues.	5
Enhancement	Refactor security-scoped resource handling into a separate method for better organization Consider moving the security-scoped resource access logic into a separate method to improve code organization and reusability. PVUI/Sources/PVSwiftUI/RootView/PVRootViewController.swift [206-217] -var securityScoped = false - -sortedUrls.forEach { url in +func handleSecurityScopedResource(_ url: URL, action: () -> Void) { + let securityScoped = url.startAccessingSecurityScopedResource() defer { if securityScoped { url.stopAccessingSecurityScopedResource() } } - - // Doesn't seem we need access in dev builds? - // if this returns false, we don't need to balance with a stop call, so just hang on to the value - securityScoped = url.startAccessingSecurityScopedResource() + action() +} +sortedUrls.forEach { url in + handleSecurityScopedResource(url) { + // Original code here + } +} + Apply this suggestion Suggestion importance[1-10]: 7 Why: Refactoring the security-scoped resource handling into a separate method enhances code organization and reusability, which is beneficial for maintaining and extending the codebase.	7

💡 Need additional feedback ? start a PR chat