Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing & scan line filters #54

Closed
cplr opened this issue Feb 11, 2015 · 11 comments
Closed

Smoothing & scan line filters #54

cplr opened this issue Feb 11, 2015 · 11 comments
Labels
enhancement improvements, enhancements, new features, additions

Comments

@cplr
Copy link
Contributor

cplr commented Feb 11, 2015

Definitely not a high priority item, but I think generally people would love different smoothing and "scan line" filters. Even better would be curved-CRT shaders :). This project has some potential shaders that could be used for the curved-CRT look: https://github.com/Swordfish90/cool-retro-term

@jasarien jasarien added the enhancement improvements, enhancements, new features, additions label Jul 13, 2015
@ghost ghost mentioned this issue Dec 21, 2015
@latzen79
Copy link

Oh!!! I need scanlines for my appletv , scanlines and moré filters

@Naatan
Copy link

Naatan commented Feb 3, 2016

This would be amazing! +1

@MysticalOS
Copy link

http://filthypants.blogspot.com/2012/03/xbr-vs-hqx-interpolation-filter.html
That's the one I'd love to see not sure of performance impact though. however ios devices are a lot more powerful than they used to be, you could possibly add such a filter with device restriction or at very least warning that they probably shouldn't be enabled on weaker devices.

@MysticalOS
Copy link

iNDS recently added a bunch of filters and they are pretty great. Worth checking out. some at higher performance cost than others but modern iOS devices are pretty strong. i tried most of those filters with no performance loss, and that's with an emulator that's already inherently more demanding.
https://github.com/WilliamLCobb/iNDS

@MysticalOS MysticalOS mentioned this issue Jul 1, 2016
@dasilvetz
Copy link

Having seen the various filters on the NES Classic console, have to say, would be great if Provenance supported similar features! +1 http://www.theverge.com/2016/9/30/13089242/nes-classic-nintendo-new-features-multiple-display-modes

@gklka
Copy link
Contributor

gklka commented Mar 17, 2017

https://github.com/OpenEmu/OpenEmu – OpenEmu for Mac also has a lof of excellent filters, maybe they can be used in this project too.

@circa-III
Copy link

Surprised this hasn't been implemented. Especially for a tvOS app. Would love to see it happen!

@braindx
Copy link
Contributor

braindx commented Nov 8, 2017

I've just added this, along with enabling 4K resolution for Apple TV 4Ks, to my branch here:
https://github.com/braindx/Provenance/tree/crt-filter

The shader is one that I just wrote but I am releasing it into the public domain. It's heavily inspired by Timothy Lottes' shader, but that one is expensive to perform in a single pass and doesn't scale down well. I wanted something that was going to be performant on my Apple TV 4K and still look decent on my phone. Of course, now that it's hooked up, the shader can be replaced with whatever shader you want by replacing the contents of shader_crt_fragment.glsl. There are also a number of settings that can be tweaked at the top of the file.

Let me know if you'd like me to make this a formal pull request.

@gklka
Copy link
Contributor

gklka commented Nov 9, 2017

Works like a charm! Will you make a pull request of it?

@braindx
Copy link
Contributor

braindx commented Nov 9, 2017

Done: #608

@sevdestruct
Copy link
Collaborator

sevdestruct commented Mar 8, 2018

Closing this. If any new filter or shader work is done, will do under new ticket or PR, such as #639 for Non-Linear Stretch feature and @braindx is looking into porting over the retroarch libraries to this sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements, enhancements, new features, additions
Projects
None yet
Development

No branches or pull requests

10 participants