Add error handler for get nft info (#243)

* Add error handler for getNFTInfo Co-authored-by: Dante <[email protected]>
Psychedelic · Nov 1, 2022 · 71bb270 · 71bb270
1 parent 74339e6
commit 71bb270
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -58,7 +58,7 @@
     "typescript": "^4.5"
   },
   "name": "@psychedelic/plug-controller",
-  "version": "0.24.8",
+  "version": "0.24.9",
   "description": "Internet Computer Plug wallet's controller",
   "main": "dist/index.js",
   "scripts": {

diff --git a/src/PlugKeyRing/modules/NetworkModule/Network.ts b/src/PlugKeyRing/modules/NetworkModule/Network.ts
@@ -117,11 +117,15 @@ export class Network {
     if (!validateCanisterId(canisterId)) {
       throw new Error(ERRORS.INVALID_CANISTER_ID);
     }
-    const agent = this.createAgent({ defaultIdentity: identity });
-    const nftActor = getNFTActor({ canisterId, agent, standard });
-    const metadata = await nftActor.getMetadata();
-    const nft = {...metadata, registeredBy: []};
-    return nft
+    try {
+      const agent = this.createAgent({ defaultIdentity: identity });
+      const nftActor = getNFTActor({ canisterId, agent, standard });
+      const metadata = await nftActor.getMetadata();
+      const nft = {...metadata, registeredBy: []};
+      return nft
+    } catch(e) {
+      throw new Error(ERRORS.CANISTER_INTERFACE_ERROR);
+    }
   }
 
   public registerNFT = async ({

diff --git a/src/constants/version.ts b/src/constants/version.ts
@@ -1 +1 @@
-export const PLUG_CONTROLLER_VERSION = "0.24.8";
+export const PLUG_CONTROLLER_VERSION = "0.24.9";
diff --git a/src/errors.ts b/src/errors.ts
@@ -28,6 +28,7 @@ export const ERRORS = {
   TOKEN_NOT_REGISTERED: 'Token not registered',
   INVALID_ACCOUNT: 'The imported account already exists',
   NFT_ALREADY_REGISTERED: 'The NFT is already registered',
+  CANISTER_INTERFACE_ERROR: 'Canister does not implement the selected standard interface',
 };
 
 export const ERROR_CODES = {
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const PLUG_CONTROLLER_VERSION = "0.24.8";
		export const PLUG_CONTROLLER_VERSION = "0.24.9";