Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range query repeated code #38

Open
smburdick opened this issue Apr 23, 2018 · 1 comment
Open

Range query repeated code #38

smburdick opened this issue Apr 23, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@smburdick
Copy link
Collaborator

In slave.c, rq_pipe_1_svc has a lot of redundant code that I think could be put into a function call. You'd need to make sure that you're passing the arguments back correctly, but as there's about 40 lines of repeat code (78-115 in that file looks a lot like 157-187) it could be made a lot more elegant.
@smburdick
Copy link
Collaborator Author

machine_failure_msg is also duplicated: this could be added to code shared by master and slave

@smburdick smburdick added the enhancement New feature or request label Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smburdick