Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI profile examples missing call to BeanMidi.enable() #26

Open
joebowbeer opened this issue Mar 21, 2017 · 0 comments
Open

MIDI profile examples missing call to BeanMidi.enable() #26

joebowbeer opened this issue Mar 21, 2017 · 0 comments

Comments

@joebowbeer
Copy link

BeanMidi.enable() must be called to add the BLE MIDI service to the bean's advertisements, but neither of the two BeanMidi examples call it:

https://github.com/PunchThrough/bean-arduino-core/blob/master/examples/profiles/MIDI.ino
https://punchthrough.com/bean/docs/guides/features/midi/

The bean's MIDI service needs to be advertised in order for it to appear in the list of available BLE MIDI devices presented to the user by iOS and Android apps.

Suggested fix: Call BeanMidi.enable() in the examples' setup function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant