(MODULES-3969) Update getvar to work on ruby 1.8.7

PuppetBSD · Oct 12, 2016 · a0f8664 · a0f8664
1 parent d990021
commit a0f8664
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/puppet/parser/functions/getvar.rb b/lib/puppet/parser/functions/getvar.rb
@@ -20,11 +20,13 @@ module Puppet::Parser::Functions
     end
 
     begin
+      result = nil
       catch(:undefined_variable) do
-        return self.lookupvar("#{args[0]}")
+        result = self.lookupvar("#{args[0]}")
       end
-
-      nil # throw was caught
+
+      # avoid relying on incosistent behaviour around ruby return values from catch
+      result
     rescue Puppet::ParseError # Eat the exception if strict_variables = true is set
     end