Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--check-updates should work with file:// dependencies #338

Open
facundobatista opened this issue Nov 17, 2018 · 0 comments
Open

--check-updates should work with file:// dependencies #338

facundobatista opened this issue Nov 17, 2018 · 0 comments

Comments

@facundobatista
Copy link
Member

facundobatista commented Nov 17, 2018

When you call fades with a file dependency (like, fades -d file:///tmp/path/to/project) it will not re-create the venv even if the project changes.

We could store the directory ctime in the fades metadata file, and use it to check updates and re-create the venv if changed.

This would be an example of use sequence:

  • fades -d file:///tmp/path/to/project: a venv is created first time
  • fades -d file:///tmp/path/to/project: the venv is reused
  • the project mentioned in the dependency is changed
  • fades -d file:///tmp/path/to/project: the venv is just reused!
  • fades --check-updates -d file:///tmp/path/to/project: the project's dir ctime changed! a new venv is created
  • fades --check-updates -d file:///tmp/path/to/project: the project's dir ctime didn't change, the venv is reused
  • the project mentioned in the dependency is changed again
  • fades --check-updates -d file:///tmp/path/to/project: the project's dir ctime changed! a new venv is created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant