Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --required-plugins and --allowed-plugins #1439

Closed
wants to merge 1 commit into from

Conversation

sigmavirus24
Copy link
Member

Closes #283
Closes #488

@asottile
Copy link
Member

asottile commented Nov 5, 2021

I'm in the middle of reworking plugin loading and this goes in the other direction of what I'm doing

essentially the planned pipeline is:

  1. initial opts
  2. load all plugins
  3. parse finalized opts
  4. (then filtering/requiring plugins would land here)
  5. then the rest of the execution pipeline

@sigmavirus24
Copy link
Member Author

load all plugins

Loading them will break things and defeat the whole purpose of adding the options in the first place unless we're defining "load" differently.

@asottile
Copy link
Member

asottile commented Nov 5, 2021

load all plugins

Loading them will break things and defeat the whole purpose of adding the options in the first place unless we're defining "load" differently.

import and parse their options -- I realize there's still situations where that breaks as well but I think in those cases it's expected that the user would uninstall or isolate using a virtualenv. whereas I expect these options to be predominantly used to prevent the plugins from executing against files

@asottile asottile deleted the plugin-loading branch March 22, 2022 23:53
@sihil
Copy link

sihil commented Jul 18, 2022

Hello. This is an awesome feature, thank you all. Any idea when you'll cut a release that includes these options? Confusingly, they are on the latest documentation but not in 4.0.1 which seems to be the latest available unless I'm mistaken. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants