Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow capitalized filenames in per-file-ignores - [merged] #917

Closed
asottile opened this issue Apr 3, 2021 · 5 comments
Closed

Allow capitalized filenames in per-file-ignores - [merged] #917

asottile opened this issue Apr 3, 2021 · 5 comments

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 29, 2019, 23:18

Merges capitalized_filenames -> master

Resolves #488

@asottile asottile added this to the 3.7.1 milestone Apr 3, 2021
@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @codecov on Jan 29, 2019, 23:19

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #290   +/-   ##
======================================
  Coverage    71.9%   71.9%           
======================================
  Files          25      25           
  Lines        2367    2367           
  Branches      393     393           
======================================
  Hits         1702    1702           
  Misses        584     584           
  Partials       81      81
Impacted Files Coverage Δ
src/flake8/utils.py 81.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f16e4...0c470a6. Read the comment docs.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 29, 2019, 23:28

Commented on tests/unit/test_utils.py line 86

before the capitalized things here were parsed as CODEs, now they are parsed as filenames because they aren't on boundaries. this changes the parsing slightly here but these are so asinine that the behaviour here is a wash at best

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 29, 2019, 23:28

resolved all discussions

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 29, 2019, 23:29

mentioned in commit ed3b133

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 29, 2019, 23:29

merged

@asottile asottile closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant