From 03f59eaf45c5786e7a9c591b8f81b1243a50b5ef Mon Sep 17 00:00:00 2001
From: Icxolu <10486322+Icxolu@users.noreply.github.com>
Date: Tue, 16 Apr 2024 22:12:18 +0200
Subject: [PATCH] fix declarative module compile error with `create_exception!`
 (#4086)

* fix declarative module compile error with `create_exception!`

* add newsfragment
---
 newsfragments/4086.fixed.md      | 1 +
 src/types/mod.rs                 | 2 +-
 tests/test_declarative_module.rs | 8 ++++++++
 3 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 newsfragments/4086.fixed.md

diff --git a/newsfragments/4086.fixed.md b/newsfragments/4086.fixed.md
new file mode 100644
index 00000000000..e9cae7733f9
--- /dev/null
+++ b/newsfragments/4086.fixed.md
@@ -0,0 +1 @@
+Fixes a compile error when exporting an exception created with `create_exception!` living in a different Rust module using the `declarative-module` feature.
\ No newline at end of file
diff --git a/src/types/mod.rs b/src/types/mod.rs
index a03d01b301a..e7aead7fbe5 100644
--- a/src/types/mod.rs
+++ b/src/types/mod.rs
@@ -252,7 +252,7 @@ macro_rules! pyobject_native_type_info(
 
         impl $name {
             #[doc(hidden)]
-            const _PYO3_DEF: $crate::impl_::pymodule::AddTypeToModule<Self> = $crate::impl_::pymodule::AddTypeToModule::new();
+            pub const _PYO3_DEF: $crate::impl_::pymodule::AddTypeToModule<Self> = $crate::impl_::pymodule::AddTypeToModule::new();
         }
     };
 );
diff --git a/tests/test_declarative_module.rs b/tests/test_declarative_module.rs
index 8e432c3ae58..2e46f4a64d1 100644
--- a/tests/test_declarative_module.rs
+++ b/tests/test_declarative_module.rs
@@ -10,10 +10,14 @@ use pyo3::types::PyBool;
 mod common;
 
 mod some_module {
+    use pyo3::create_exception;
+    use pyo3::exceptions::PyException;
     use pyo3::prelude::*;
 
     #[pyclass]
     pub struct SomePyClass;
+
+    create_exception!(some_module, SomeException, PyException);
 }
 
 #[pyclass]
@@ -61,6 +65,10 @@ mod declarative_module {
     #[pymodule_export]
     use super::some_module::SomePyClass;
 
+    // test for #4036
+    #[pymodule_export]
+    use super::some_module::SomeException;
+
     #[pymodule]
     mod inner {
         use super::*;