Skip to content

Commit

Permalink
Merge pull request #31 from rjtavares/pandas_additional_columns
Browse files Browse the repository at this point in the history
added option to parse additional columns when calling to_pandas
  • Loading branch information
koenvo authored Jul 1, 2020
2 parents 879473c + 374a3b0 commit 5859583
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 3 deletions.
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,21 @@ new_dataset = Transformer.transform_dataset(
)
```

### Adding additional columns to DataFrame

You can add more information to the DataFrame returned by `to_pandas` by passing a Dictionary in the format `{'column_name': function or scalar}`. Function should take a frame (for tracking data) or an event (for event data) as argument and return a valid input for a DataFrame.

```python
from kloppy import datasets, to_pandas
dataset = datasets.load("statsbomb")

# Statsbomb events may include a list of related events.
# This function returns the first event from that list, if it exists.
get_first_related_event = lambda x: x.raw_event['related_events'][0] if 'related_events' in x.raw_event else None
to_pandas(dataset, additional_columns={'related_event': get_first_related_event, 'match': 'test1'})
```


# Contributing to kloppy
All contributions, bug reports, bug fixes, documentation improvements, enhancements, and ideas are welcome.

Expand Down
18 changes: 15 additions & 3 deletions kloppy/helpers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Callable, TypeVar, Dict
from typing import Callable, TypeVar, Dict, Union

from . import (
TRACABSerializer,
Expand Down Expand Up @@ -193,7 +193,7 @@ def _event_to_pandas_row_converter(event: Event) -> Dict:


def to_pandas(
dataset: Dataset, _record_converter: Callable = None
dataset: Dataset, _record_converter: Callable = None, additional_columns: Dict = None
) -> "DataFrame":
try:
import pandas as pd
Expand All @@ -211,7 +211,19 @@ def to_pandas(
else:
raise Exception("Unknown dataset type")

return pd.DataFrame.from_records(map(_record_converter, dataset.records))
def generic_record_converter(record: Union[Frame, Event]):
row = _record_converter(record)
if additional_columns:
for k, v in additional_columns.items():
if callable(v):
value = v(record)
else:
value = v
row.update({k: value})

return row

return pd.DataFrame.from_records(map(generic_record_converter, dataset.records))


__all__ = [
Expand Down

0 comments on commit 5859583

Please sign in to comment.