CI: Build musllinux aarch64 and x86_64 wheels, and native macOS arm64 wheels
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
force-pushed
the
build-musl-and-macos-arm64-wheels
branch
2 times, most recently
from
bc5003a
to
4e69950
Compare
|
This should be ready for review now, please check the logs here: https://github.com/agriyakhetarpal/pywt/actions/runs/8255410993/job/22581797957 All job produce a singleton wheel, except for the GNU/Linux jobs that produce two – both musllinux and manylinux wheels. Edit: all jobs are passing! |
agriyakhetarpal
commented
Mar 12, 2024
agriyakhetarpal
commented
Mar 12, 2024
agriyakhetarpal
commented
Mar 12, 2024
CI: exclude macOS runners based on architecture
agriyakhetarpal
force-pushed
the
build-musl-and-macos-arm64-wheels
branch
from
4e69950
to
25d28dc
Compare
rgommers
reviewed
Mar 12, 2024
There was a problem hiding this comment.
This all looks like it works as advertised, nice work @agriyakhetarpal. I only have a few minor comments for maintainability and future-proofing.
|
All wheels are getting built, please see this workflow run: https://github.com/agriyakhetarpal/pywt/actions/runs/8262339804 |
rgommers
changed the title
musllinux aarch64 and x86_64 wheels, and native macOS arm64 wheelsmusllinux aarch64 and x86_64 wheels, and native macOS arm64 wheels
rgommers
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following:
macos-14GitHub Actions runners to target macOS arm64 wheels natively, without cross-compilationbuild_linux_aarch64_wheelsandbuild_linux_x86_64_wheelsjobs to include MUSL wheels (which were previously being skipped).Footnotes
This PR: