Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different colors for keywords and types? #5

Open
failable opened this issue Mar 4, 2024 · 2 comments
Open

Use different colors for keywords and types? #5

failable opened this issue Mar 4, 2024 · 2 comments

Comments

@failable
Copy link

failable commented Mar 4, 2024

image

Compared to

image

Although the original theme did not seem to use color for types, the current version of this theme uses the same color (red) for keywords and types, making the entire window appear quite red at times...

@PyaeSoneAungRgn
Copy link
Owner

Thanks you, i will try to fix. Btw if you know how to fix, feel free to submit a PR.

@verhovsky
Copy link
Contributor

verhovsky commented May 9, 2024

GitHub's theme is defined here (I think)

https://github.com/primer/github-syntax-theme-generator/blob/main/lib/themes/light.json

https://github.com/primer/github-syntax-theme-generator/blob/main/lib/themes/dark.json

I'm surprised you can't do an exact conversion of this JSON to Zed's JSON since both GitHub and Zed use tree-sitter for parsing most languages, but from my brief look it seems like they might have different names for syntax nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants