fix double code for string value

PyaeSoneAungRgn · Feb 8, 2023 · d999365 · d999365
1 parent df1618b
commit d999365
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/ToRawSqlServiceProvider.php b/src/ToRawSqlServiceProvider.php
@@ -13,7 +13,15 @@ public function boot(): void
     {
         Builder::macro('toRawSql', function (): string {
             /** @var \Illuminate\Database\Eloquent\Builder $this */
-            return Str::replaceArray('?', $this->getBindings(), $this->toSql());
+            $bindings = [];
+            foreach ($this->getBindings() as $value) {
+                if (is_string($value)) {
+                    $bindings[] = "'{$value}'";
+                } else {
+                    $bindings[] = $value;
+                }
+            }
+            return Str::replaceArray('?', $bindings, $this->toSql());
         });
     }
 

diff --git a/tests/ToRawSqlTest.php b/tests/ToRawSqlTest.php
@@ -9,5 +9,5 @@
                     ->where('votes', '>', 50);
             })
             ->toRawSql()
-    )->toBe('select * from `users` where `votes` > 100 or (`name` = Abigail and `votes` > 50)');
+    )->toBe("select * from `users` where `votes` > 100 or (`name` = 'Abigail' and `votes` > 50)");
 });