[DA] Sinkhorn LpL1 transport to work on JAX #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 85 85
Lines 16898 16928 +30
=======================================
+ Hits 16334 16364 +30
Misses 564 564 |
kachayev
changed the title
There was a problem hiding this comment.
Thank you for this PR @kachayev,
sorry for the late review on this PR. I put some remarks to ensure compatibility with all backends. Could you take them into account and mention the fix in the RELEASE.md file ?
Best,
Cédric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
This PR presents a vectorized implementation of LpL1 transport algorithms for domain adaptation, along with all the requisite modifications to ensure compatibility of the
ot.damodule with JAX.Motivation and context / Related issue
Continuing the effort to enable Domain Adaptation functionality in JAX. See also previously introduced changes in PR #587 for details.
How has this been tested (if it applies)
The tests have been updated. Additionally, a dedicated test has been included to verify that the vectorized implementation produces the same results as the original code.
PR checklist