Skip to content

Introduce MerkleChipOptimized in sinsemilla_opt/merkle #287

Introduce MerkleChipOptimized in sinsemilla_opt/merkle

Introduce MerkleChipOptimized in sinsemilla_opt/merkle #287

GitHub Actions / Clippy (beta) failed Apr 29, 2024 in 2s

Clippy (beta)

33 errors, 110 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 33
Warning 110
Note 0
Help 0

Versions

  • rustc 1.79.0-beta.1 (6b544f5ff 2024-04-28)
  • cargo 1.79.0-beta.1 (b60a15551 2024-04-26)
  • clippy 0.1.79 (6b544f5 2024-04-28)

Annotations

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 458 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

non-local `impl` definition, they should be avoided as they go against expectation

warning: non-local `impl` definition, they should be avoided as they go against expectation
   --> halo2_gadgets/src/ecc/chip/mul.rs:422:5
    |
422 | /     construct_uint! {
423 | |         struct U256(4);
424 | |     }
    | |_____^
    |
    = help: move this `impl` block outside the of the current function `decompose_for_scalar_mul`
    = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
    = note: the macro `$crate::impl_mul_for_primitive` may come from an old version of the `uint` crate, try updating your dependency with `cargo update -p uint`
    = note: `#[warn(non_local_definitions)]` on by default
    = note: this warning originates in the macro `$crate::impl_mul_for_primitive` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 127 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:34
    |
127 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 118 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:34
    |
118 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 103 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:34
    |
103 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 1066 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Iterator::fold` on a type that implements `Try`

warning: usage of `Iterator::fold` on a type that implements `Try`
    --> halo2_proofs/src/dev.rs:1066:30
     |
1066 | ...                   .fold(Ok(()), |acc, res| acc.and(res))
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
     = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
     = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

Check warning on line 414 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:414:33
    |
414 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs