From 20ef938ec2f3cd6cb83719217b66196fa46c95e6 Mon Sep 17 00:00:00 2001 From: Vivek Arte <46618816+vivek-arte@users.noreply.github.com> Date: Thu, 31 Oct 2024 15:03:54 +0530 Subject: [PATCH] Applying suggestions from ZIP review Co-authored-by: Daira-Emma Hopwood --- zips/zip-0227.rst | 4 ++-- zips/zip-0230.rst | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/zips/zip-0227.rst b/zips/zip-0227.rst index e27784e29..9dac2581d 100644 --- a/zips/zip-0227.rst +++ b/zips/zip-0227.rst @@ -126,7 +126,7 @@ Issuance authorizing key generation for hierarchical deterministic wallets The issuance authorizing key is generated using the Hardened-only key derivation process defined in ZIP 32 [#zip-0032-hardened-only-key-derivation]_. For the :math:`\mathsf{Issuance}` context, we define the following constants: -- :math:`\mathsf{Issuance.\!MKGDomain} := \texttt{"ZIP32ZSAIssue_V1"}` +- :math:`\mathsf{Issuance.\!MKGDomain} := \texttt{"ZcashSA_Issue_V1"}` - :math:`\mathsf{Issuance.\!CKDDomain} := \mathtt{0x81}\!` Let :math:`S` be a seed byte sequence of a chosen length, which MUST be at least 32 and at most 252 bytes. @@ -134,7 +134,7 @@ We define the master extended issuance key :math:`m_{\mathsf{Issuance}} := \math We use hardened-only child key derivation as defined in ZIP 32 [#zip-0032-hardened-only-child-key-derivation]_ for the issuance authorizing key. -:math:`\mathsf{CDKsk}((\mathsf{sk}_{par},\mathsf{c}_{par}), i) \rightarrow (\mathsf{sk}_{i}, \mathsf{c}_{i})` +:math:`\mathsf{CKDsk}((\mathsf{sk}_{par},\mathsf{c}_{par}), i) \rightarrow (\mathsf{sk}_{i}, \mathsf{c}_{i})` - Return :math:`\mathsf{CKDh}^{\mathsf{Issuance}}((\mathsf{sk}_{par},\mathsf{c}_{par}), i)\!` diff --git a/zips/zip-0230.rst b/zips/zip-0230.rst index 7052c38e6..77eac1422 100644 --- a/zips/zip-0230.rst +++ b/zips/zip-0230.rst @@ -351,10 +351,10 @@ An issuance note, ``IssueNote`` contains the following fields: | | | |:math:`\mathsf{AssetBase^{Orchard}}\!`, as defined in 'ZIP 227'. | +-----------------------------+--------------------------+--------------------------------------+--------------------------------------------------------------------+ |``32`` |``rho`` |``byte[32]`` |This is defined and encoded in the same manner as for Orchard | -| | | |notes in protocol §3.2 'Notes'. | +| | | |notes in protocol §3.2.1 'Note Plaintexts and Memo Fields'. | +-----------------------------+--------------------------+--------------------------------------+--------------------------------------------------------------------+ |``32`` |``rseed`` |``byte[32]`` |The ``rseed`` field of the note, encoded as for Orchard notes in | -| | | |protocol §3.2 'Notes'. | +| | | |protocol §3.2.1 'Note Plaintexts and Memo Fields'. | +-----------------------------+--------------------------+--------------------------------------+--------------------------------------------------------------------+