Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant copies of scalars in OpenACC parallel directive #1

Open
fspiga opened this issue Feb 18, 2022 · 0 comments
Open

Redundant copies of scalars in OpenACC parallel directive #1

fspiga opened this issue Feb 18, 2022 · 0 comments

Comments

@fspiga
Copy link
Member

fspiga commented Feb 18, 2022

https://github.com/QEF/qe_test_openacc/blob/phonon_gpu_develop/PHonon/PH/dvqpsi_us.f90#L141

In both OpenACC parallel and kernel directives it is not needed to do copyin/copyout/create (any data clause actually) for scalars. Scalars are passed to the GPu kernel generated by the compiler as parameters of the kernel function call. Forcing them with copyin/copyout results is extra unnecessary data movement.

This:

copyin(fact, u1, u2, u3, gu0)

can be purged.

Similar here

!$acc parallel loop private(itmp,gtau,gu) present(eigts1, eigts2, eigts3, g, mill,drhoc) copyin(u1,u2,u3,drc,fact,mu,gu0)

OscarBaseggio pushed a commit that referenced this issue May 24, 2022
Spin polarized wannier2odd

Closes #4 and #1

See merge request elinscott/qe_koopmans!15
OscarBaseggio pushed a commit that referenced this issue May 24, 2022
Kcw for qef

Closes #3, #1, #7, #8, #4, and #6

See merge request QEF/q-e!1805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant