Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Create Qbeast Table in one step #371

Open
osopardo1 opened this issue Jul 30, 2024 · 1 comment
Open

Unify Create Qbeast Table in one step #371

osopardo1 opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
type: enhancement Improvement of existing feature or code

Comments

@osopardo1
Copy link
Member

osopardo1 commented Jul 30, 2024

Right now, the code to create a Qbeast Table without data (no SAVE AS), is done in two steps:

  1. Create an empty data frame and save it in the Location.
  2. Convert the Delta Table to the Qbeast Table with ConvertToQbeastCommand.

It is executed like that because we do not have access to methods in the CreateDeltaTableCommand, nor can we delegate the creation to that object. Otherwise (if we call directly CreateDeltaTableCommand), the table would be created in the Catalog as "delta", and the whole operation would fail.

The idea is to do both in the same transaction.
Perhaps it is a good moment to build a CreateQbeastTableCommand to centralize the process.

@osopardo1 osopardo1 added the type: enhancement Improvement of existing feature or code label Jul 30, 2024
@osopardo1 osopardo1 changed the title Unify Create Qbeast Table in one transaction Unify Create Qbeast Table in one step Oct 21, 2024
@fpj
Copy link
Contributor

fpj commented Oct 21, 2024

We need a design document for this issue to understand clearly the implications of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing feature or code
Projects
None yet
Development

No branches or pull requests

2 participants