feat(client): Show Selection on Map #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force Pushed |
2 tasks
|
updated PR description to include my PR to remove the thread from the hud |
mafewtm
approved these changes
Jan 16, 2025
FjamZoo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature shows a user where exactly on the map his selection for apartment would be, useful for those who dont know exactly where the GTA Online apartments are located.
Small Issue
One small issue is one I bought up here (qbox contributors channel) is theNo issues, Hud PR Mergedqbx_hudcurrently has a thread every 500ms to disable the big map. Without its removal it causes the map to flicker in this selection screenPreview
Checklist
Requirements
qbx_hudPR: Qbox-project/qbx_hud#33