Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE missing in pypi sdist #189

Open
dvzrv opened this issue Jul 30, 2019 · 4 comments · May be fixed by #220
Open

LICENSE missing in pypi sdist #189

dvzrv opened this issue Jul 30, 2019 · 4 comments · May be fixed by #220

Comments

@dvzrv
Copy link

dvzrv commented Jul 30, 2019

It's usually best practice to include the LICENSE file in any source code tarball.

Some Linux distributions (are required to) include them when packaging, others (such as Arch Linux) might have a package with default licenses, which is then referred to.

For maximum compatibility, it would be very awesome, if you could include the LICENSE in the sdist! Thanks!

@Qirky Qirky closed this as completed Jul 30, 2019
@dvzrv
Copy link
Author

dvzrv commented Jul 30, 2019

@Qirky thanks for the short turnaround! :)

@dvzrv
Copy link
Author

dvzrv commented Jul 30, 2019

Hm, but it seems the LICENSE is still not included in the sdist of 0.7.34

@Qirky
Copy link
Owner

Qirky commented Jul 31, 2019

It's been added to the setup.py file so I have no idea why it isn't being uploaded. The License version number is on the PyPI page (cc-by-sa-4.0) but the file isn't included...

@Qirky Qirky reopened this Jul 31, 2019
@kyluca kyluca linked a pull request Oct 29, 2019 that will close this issue
@kyluca
Copy link

kyluca commented Oct 29, 2019

I believe this PR should be sufficient to get the LICENSE file into the source dist #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants