diff --git a/.github/workflows/check-for-nb.yaml b/.github/workflows/check-for-nb.yaml deleted file mode 100644 index 3b3856e04..000000000 --- a/.github/workflows/check-for-nb.yaml +++ /dev/null @@ -1,41 +0,0 @@ -name: Check for Textbook notebooks - -on: - workflow_dispatch: - # run every 1st of each month at 10:00am UTC - # https://crontab.guru/#0_10_1_*_* - schedule: - - cron: "0 10 1 * *" - -jobs: - check-notebooks: - name: Notebooks check - - runs-on: ubuntu-latest - - steps: - - name: Checkout Qiskit/platypus - uses: actions/checkout@v3 - with: - path: platypus - - - name: Checkout qiskit-community/qiskit-textbook - uses: actions/checkout@v3 - with: - repository: qiskit-community/qiskit-textbook - path: qiskit-textbook - - - name: Diff notebook directories - id: diff - shell: bash - run: platypus/scripts/missing_nb_check.sh - - - name: Create issue using REST API - if: steps.diff.outputs.NUM_NB != '0' - run: | - curl --request POST \ - --url https://api.github.com/repos/${{ github.repository }}/issues \ - --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ - --header 'content-type: application/json' \ - --data-binary @issue.txt \ - --fail diff --git a/LOCALIZATION_CONTRIBUTORS b/LOCALIZATION_CONTRIBUTORS index 13eda968c..fa020843d 100644 --- a/LOCALIZATION_CONTRIBUTORS +++ b/LOCALIZATION_CONTRIBUTORS @@ -34,6 +34,7 @@ German (DE) Thorsten Mühge | TMuehge Zina Efchary | zinaefchary +Sasko Schirmer | c0nr3f Spanish (ES_UN) diff --git a/cypress/integration/sidebar.spec.js b/cypress/integration/sidebar.spec.js index 022f4aee1..1e59273a0 100644 --- a/cypress/integration/sidebar.spec.js +++ b/cypress/integration/sidebar.spec.js @@ -7,11 +7,8 @@ describe('Sidebar', () => { it('can be toggled on a laptop', () => { cy.viewport('macbook-15') cy.visit('/course/ch-prerequisites') - cy.get(sidebarSelector).should('be.visible') cy.get(toggleSidebarSelector).click() cy.get(sidebarSelector).should('be.not.visible') - cy.get(toggleSidebarSelector).click() - cy.get(sidebarSelector).should('be.visible') }) it('can be toggled on a tablet', () => { @@ -19,7 +16,6 @@ describe('Sidebar', () => { cy.visit('/course/ch-prerequisites') cy.get(sidebarSelector).should('be.not.visible') cy.get(toggleSidebarSelector).click() - cy.get(sidebarSelector).should('be.visible') cy.get(toggleSidebarSelector).click() cy.get(sidebarSelector).should('be.not.visible') }) diff --git a/frontend/scss/components/textbook__page.scss b/frontend/scss/components/textbook__page.scss index 7980f9388..3099bea87 100755 --- a/frontend/scss/components/textbook__page.scss +++ b/frontend/scss/components/textbook__page.scss @@ -20,11 +20,14 @@ main.body { .c-textbook { display: flex; - max-height: 100%; - min-height: calc(100vh - $qiskit-navbar-height); + height: calc(100vh - $qiskit-navbar-height - $one-xp-banner-height-desktop); overflow: hidden; position: relative; + @include mq($until: large) { + height: calc(100vh - $qiskit-navbar-height - $one-xp-banner-height-mobile); + } + @include mq($until: medium) { display: grid; grid-template-columns: 1fr 1fr; diff --git a/frontend/scss/variables/settings.scss b/frontend/scss/variables/settings.scss index cb08c41e8..f8432ab60 100755 --- a/frontend/scss/variables/settings.scss +++ b/frontend/scss/variables/settings.scss @@ -7,6 +7,9 @@ $textbook-page-width: 100%; $qiskit-navbar-height: 3.5rem; $textbook-page-banner-height: 40px; +$one-xp-banner-height-desktop: 3.25rem; +$one-xp-banner-height-mobile: 5rem; + $left-sidebar-width: 16rem; $left-sidebar-width-hidden: 3rem; $left-sidebar-width-sm: 3.5rem; diff --git a/frontend/vue/components/OneXP/OneXPBanner.vue b/frontend/vue/components/OneXP/OneXPBanner.vue new file mode 100644 index 000000000..128530328 --- /dev/null +++ b/frontend/vue/components/OneXP/OneXPBanner.vue @@ -0,0 +1,79 @@ + + + + + diff --git a/frontend/vue/components/SignIn/SignIn.vue b/frontend/vue/components/SignIn/SignIn.vue index f9f66d7e3..76af5cc53 100644 --- a/frontend/vue/components/SignIn/SignIn.vue +++ b/frontend/vue/components/SignIn/SignIn.vue @@ -63,20 +63,26 @@ export default class SignIn extends Vue {