Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PendingDeprecations to Deprecations in the circuit library #13604

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Move PendingDeprecations to Deprecations in the circuit library #13604

wants to merge 19 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 24, 2024 •
edited
Loading

Summary

The circuit library modernization from #13046 introduced some pending deprecations that this PR is moving to deprecations.

reno is still missing.

@1ucian0 1ucian0 mentioned this pull request Dec 25, 2024
Open
40 tasks
@1ucian0 1ucian0 linked an issue Feb 4, 2025 that may be closed by this pull request
Deprecate in 1.4 the pending deprecations from the 1.* cycle #13589
Open
40 tasks
@Cryoris
Copy link
Contributor

Cryoris commented Feb 7, 2025

We could just have a single reno for the deprecation of BlueprintCircuit and mention the deprecation of all subclasses therein. That would be a bit cleaner for the users than having multiple 🙂

Cryoris
Cryoris reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, this LGTM but it seems to only miss the catches in the tests 🙂

@1ucian0 1ucian0 changed the base branch from stable/1.4 to main February 10, 2025 13:19
Cryoris and others added 18 commits February 10, 2025 17:43
@Cryoris
blueprint deprecation + reno
5c1420b
@1ucian0
Merge branch 'main' into followup/13241/1
6db06ef
@1ucian0
Merge branch 'main' of github.com:Qiskit/qiskit-terra into followup/1…
4d30309 
…3241/1
@1ucian0
unittest test.python.transpiler.test_star_prerouting
8418359
@1ucian0
test.python.transpiler.test_solovay_kitaev
a614735
@1ucian0
test.python.transpiler.test_linear_functions_passes
fd394dd
@1ucian0
unittest test.python.synthesis.test_qft_synthesis
b848848
@1ucian0
test.python.synthesis.test_cz_synthesis
4257e03
@1ucian0
test.python.transpiler.test_parameterizedgate_translator
c5e7000
@1ucian0
test.python.quantum_info.operators.test_operator
3f1e59a
@1ucian0
test.python.primitives.test_statevector_sampler
cfac75b
@1ucian0
test.python.primitives.test_sampler
6a11a16
@1ucian0
test.python.primitives.test_statevector_estimator
f2f65d4
@1ucian0
test.python.primitives.test_estimator
9bdad15
@1ucian0
test.python.primitives.test_backend_sampler_v2
e80b209
@1ucian0
test.python.primitives.test_backend_sampler
d094e95
@1ucian0
test.python.primitives.test_backend_estimator_v2
677a6db
@1ucian0
test.python.primitives.test_backend_estimator
6267f71
@1ucian0 1ucian0 linked an issue Feb 15, 2025 that may be closed by this pull request
Deprecate BlueprintCircuit in 2.0 #13760
Open
@1ucian0 1ucian0 self-assigned this Feb 20, 2025
@1ucian0 1ucian0 added this to the 2.0.0 milestone Feb 20, 2025
@1ucian0
Copy link
Member Author

1ucian0 commented Feb 20, 2025

Most of the problems are coming from an internal call to a deprecated method:

qiskit/circuit/library/standard_gates/x.py", line 1148, in __init__
    num_ancilla_qubits = self.__class__.get_num_ancilla_qubits(num_ctrl_qubits)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

There is also some issues with BlueprintCircuit subclasses. From @Cryoris :

There's currently 5 subclasses:
QFT and NLocal are already deprecated
all others should be taken care of by #13371

Still working on the rest.

@1ucian0 1ucian0 added the on hold Can not fix yet label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@1ucian0 1ucian0

Labels
on hold Can not fix yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Deprecate BlueprintCircuit in 2.0 Deprecate in 1.4 the pending deprecations from the 1.* cycle
2 participants
@1ucian0 @Cryoris