Check for gate parameter

[MozammilQ]

Summary

This PR aims to fix an issue withTarget.has_calibration() and Target.get_calibration() when passed with parameterized gates didn't work as expected.

Refer to issues for more information.
#11658
#11657

Details and comments

To be precise, Target.has_calibration() didn't check if the calibration if present is present for a particular gate with a particular parameter,
and,
Target.get_calibration() didn't get the calibration for the gate if present is present for a particular gate with a particular parameter, when passed as a parameter as args, the method tried to bind this args with a parameter in the schedule, which was not the intention of this particular args.

So, the signature of Target.has_calibration includes a new argument operation_params which has to be passed with the parameter of the Gate if the Gate is parameterized.

Similarly, the signature of Target.get_calibration also includes a new argument operation_params which has to be passed with the parameter of the Gate if the Gate is parameterized. In the case of args argument in this function, it should be passed with the values to be bound with the parameter of the schedule which has been attached to this particular gate as its calibration.

fixes #11658
fixes #11657

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

• @Qiskit/terra-core
• @nkanazawa1989

[coveralls]

Pull Request Test Coverage Report for Build 9136334258

Details

• 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.006%) to 89.607%

---

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	4	92.62%

Totals
Change from base Build 9134495129:	0.006%
Covered Lines:	62302
Relevant Lines:	69528

---

💛 - Coveralls

[MozammilQ]

Reviewer's comment anticipated! :)
I am not super satisfied with putting None here.
Here, the parameter node_op.params has the actual list of float parameters to bind with the Gate's parameters stored in the target which is a parameter(variable). That is why I had to put None just to keep the function's behavior similar to its previous version.

[MozammilQ]

Considering theta maps to amp, sigma, and, beta. The emphasis here is just to prove that multiple *args could be successfully bind if equal number of parameter(variable) present in the actual Schedule

[MozammilQ]

@1ucian0 , pulse features are being deprecated in Qiskit, and being moved to Qiskit Dynamics, is this PR required anymore?
If yes, in what direction the PR should be heading?

[eliarbel]

Hi @MozammilQ , thanks for working on this! Yes, although Pulse is being deprecated in Qiskit 1.3 and will be removed in 2.0, it would still be good to have this as part of the extended support window for the 1.x series.

For moving forward please note the following:

1. Update your branch to include all the recent changes including the move Target to Rust. We still have Target class in target.py with has_calibration and get_calibration there so your changes are still valid.
2. Once this PR is ready we will want to merge it into the 1.4 branch and not 2.0.

I also left some line comments after partially reviewing this.

[eliarbel]

Why not ordering like this?

    def get_calibration(
        self,
        operation_name: str,
        qargs: tuple[int, ...],
        *args: ParameterValueType,
        operation_params: list[float] | None = None,
        **kwargs: ParameterValueType,
    ) -> Schedule | ScheduleBlock:

[MozammilQ]

Done!

[coveralls]

Pull Request Test Coverage Report for Build 11995012388

Details

• 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
• 16 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.009%) to 88.945%

---

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	4	93.23%
crates/qasm2/src/parse.rs	12	97.15%

Totals
Change from base Build 11977726745:	0.009%
Covered Lines:	79415
Relevant Lines:	89286

---

💛 - Coveralls

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

• @Qiskit/terra-core
• @nkanazawa1989

[MozammilQ]

@eliarbel , please have a look :)