Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7? #67

Open
Delgan opened this issue Jan 13, 2019 · 2 comments
Open

Drop support for Python 2.7? #67

Delgan opened this issue Jan 13, 2019 · 2 comments

Comments

@Delgan
Copy link
Collaborator

Delgan commented Jan 13, 2019

Hello @Qix-.

So, to explain you the problem I'm facing: I have implemented a few fixes for some edge cases, but I'm not sure how to handle it properly for Python 2.7.

These fixes implies working with strings formatting and encoding, which is a pain to deal with in Python 2.

Considering that official Python 2 support is ending in less than one year, what are your thoughts on tagging better_exceptions v0.2.2 as the "final" stable release for Python 2, and making v0.3.0 Python 3 only?

If you wish to maintain compatibility for Python 2.7, I think I could manage to make it work for all versions. But I'm afraid that it will clutter the codebase while introducing prone to errors string manipulations. This is why I prefer to ask you first: does it worth it?

@Qix-
Copy link
Owner

Qix- commented Jan 13, 2019

Didn't think it would ever happen.

https://python3statement.org

Yes, I think this is a good idea. I'd go so far as making v1 python 3 only.

@Delgan
Copy link
Collaborator Author

Delgan commented Jan 13, 2019

@Qix- Glad to hear that. ❤️

How do you want to handle the transition?

For now I created a new python3_only branch on top of which I will open pull requests for my fixes. Except if you prefer this to be managed by master directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants