Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More correct pixel positioning #34

Open
nick87720z opened this issue Jan 4, 2014 · 4 comments
Open

More correct pixel positioning #34

nick87720z opened this issue Jan 4, 2014 · 4 comments

Comments

@nick87720z
Copy link

I can guess, this trouble could cause original author to disable antialiasing for contours for sharp look. Same problem may be seen on recently added tooltip border - horizontal and vertical lines are thick. Tooltip borders actually look better above background with moderate colors, but above something black (xterm) problem appears clear.

Pixels are squares, and exact integer position usually points not exactly to pixels, but between them - i got this much time ago from some cairo-dock docs.

I.e., for point 10,14 exact coords parameters should be 10.5,14.5.

@yuyichao
Copy link
Member

yuyichao commented Jan 5, 2014

Errr, I don't remember having done anything to tooltip border recently. Could you please use more pictures to show exactly what you mean in your bug reports (not just this one)? It's really hard for me to figure out which part you are talking about given the complexity of QtCurve and my familiarity with it.

@nick87720z
Copy link
Author

It eventually appeared during your last work since 1.8.17. I don't recall when i could see it earlier :)
Screenshot below demonstrates same tooltip on moderate and black (konsole) backgrounds:
qtcurve-tooltip-border

Also about what i said about disabled AA for borders: i'm not sure, is it really so, as otherwise same problem should affect gtk2 version too, but there is all fine.

@yuyichao
Copy link
Member

yuyichao commented Jan 5, 2014

Well, what's different between 1.8.17 and master is that shadow (which is NOT part of the window) is drawn at runtime. And it should be the same for all versions (gtk2, qt4, qt5) because it is not drawn by either cairo, Gtk/GDK or Qt.

I'm still not sure what's the problem you are talking about but a known problem is that the new shadow gradient (and color) is not polished yet (in fact it is just some random functions and colors that is reasonably good...) and is not corner radius aware either (the old implementation is just a static png image and therefore cannot be radius aware).

@nick87720z
Copy link
Author

Hm, its looks is far from shadow. More like some tiny halo, which would be good for dark colors. Too light for light color scheme. It needs either option to be configurable like window shadows or just use same shadow as windows (for menu it could be inactive as well - e.g., in some gtk apps popup menus may be sticked to be persistent with special menu item on top).

Or indeed, it could allow either use common shadow or own, if has contrast colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants