From 9c29ee241241afe2567730f175b1c89bf0c7ee89 Mon Sep 17 00:00:00 2001 From: rturrado Date: Fri, 18 Oct 2024 12:24:22 +0200 Subject: [PATCH] Set files-changed-only and format-review to false. If we expect some of our PRs to have a large diff, then we should disable any features that rely on having diff information: - lines-changed-only, - files-changed-only, - format-review, and - tidy-review. For a more detailed explanation: https://github.com/cpp-linter/cpp-linter-action/issues/274#issuecomment-2419903580 --- .github/workflows/linters.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/linters.yaml b/.github/workflows/linters.yaml index cd3bc7cd..b7dc446d 100644 --- a/.github/workflows/linters.yaml +++ b/.github/workflows/linters.yaml @@ -22,8 +22,6 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: extensions: 'cpp,hpp' - files-changed-only: 'true' - format-review: 'true' style: 'file' # use .clang-format config file tidy-checks: '-*' # disable clang-tidy checks version: 18