Canvas: Remove Open Editor option from context menu when in normal ed…

…itor mode grafana#52186
QuackatronHQ · Jul 13, 2022 · eb5a96e · eb5a96e
1 parent 2520d8f
commit eb5a96e
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/public/app/plugins/panel/canvas/CanvasContextMenu.tsx b/public/app/plugins/panel/canvas/CanvasContextMenu.tsx
@@ -91,20 +91,22 @@ export const CanvasContextMenu = ({ scene }: Props) => {
           }}
           className={styles.menuItem}
         />
-        <MenuItem
-          label={inlineEditorOpen ? 'Close Editor' : 'Open Editor'}
-          onClick={() => {
-            if (scene.inlineEditingCallback) {
-              if (inlineEditorOpen) {
-                activePanel.panel.inlineEditButtonClose();
-              } else {
-                scene.inlineEditingCallback();
+        {!scene.isPanelEditing && (
+          <MenuItem
+            label={inlineEditorOpen ? 'Close Editor' : 'Open Editor'}
+            onClick={() => {
+              if (scene.inlineEditingCallback) {
+                if (inlineEditorOpen) {
+                  activePanel.panel.inlineEditButtonClose();
+                } else {
+                  scene.inlineEditingCallback();
+                }
               }
-            }
-            closeContextMenu();
-          }}
-          className={styles.menuItem}
-        />
+              closeContextMenu();
+            }}
+            className={styles.menuItem}
+          />
+        )}
       </>
     );
   };