Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More rust tests for update commitment JNI function #13

Open
dragan2234 opened this issue Aug 18, 2023 · 1 comment
Open

More rust tests for update commitment JNI function #13

dragan2234 opened this issue Aug 18, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dragan2234
Copy link
Collaborator

Make more tests for the work done here: #10
This has only trivial tests using Fr::0 and Fr::1, it would be good to have more complicated and real-world values tests.

For example:

  1. Commit to 256 values(field elements).
  2. Update i-th value
  3. Commit to 256 values where i-th value is already changed.

Compare if 2nd result is equal to 3rd.

@dragan2234 dragan2234 added the good first issue Good for newcomers label Aug 18, 2023
@MatteoMer
Copy link
Collaborator

It would also be good to have theses tests (existing+the one in the issue) written as java tests (not only rust), calling the JNI rust lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants