Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case for chunkifyCode #12

Open
thomas-quadratic opened this issue Nov 17, 2023 · 0 comments
Open

Edge case for chunkifyCode #12

thomas-quadratic opened this issue Nov 17, 2023 · 0 comments

Comments

@thomas-quadratic
Copy link
Member

Description

Currently, chunkifyCode in TrieKeyAdaptor has been implemented and tested on two contract's bytecode.
However, we are uncertain of the validity of the current implementation in the case of PUSH32.
The ultimate edge-case would be to have a PUSH32 opcode at a position a multiple of 31. This would mean that the next code chunk is made of only push data, and that data even spills one byte into the next-next chunk.

Expected

  1. A testcase for the described edge-case. It should be added to the JSON test file.
  2. If test fails, correct the current implementation so that it passes.
neotheprogramist pushed a commit to visoftsolutions/besu-verkle-trie-old that referenced this issue Nov 18, 2023
@thomas-quadratic
PedersenHash wraps the besu-native pedersen commit and hash function (Q…
cf00bfd 
…uadratic-Labs#12)

PedersenHash wraps the besu-native pedersen commit and hash functions.
It is used now in TrieKeyAdaptor to generate trie-keys

Signed-off-by: Thomas Zamojski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomas-quadratic