Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Python configuration utility #5346

Closed
wants to merge 1 commit into from
Closed

Adds Python configuration utility #5346

wants to merge 1 commit into from

Conversation

aarjaneiro
Copy link
Contributor

Description

Adds tool to automatically locate python shared library for Linux and OSX users

Related Issue

QuantConnect/pythonnet#48

Motivation and Context

Prevents need to manually locate shared library and dll config file.

Requires Documentation Change

No

How Has This Been Tested?

Following usage on 5.10.15-1-MANJARO, allows for Python tests to run successfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • [ x] My code follows the code style of this project.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@aarjaneiro aarjaneiro marked this pull request as ready for review February 26, 2021 05:41
@Martin-Molinero
Copy link
Member

Hey @aarjaneiro! Thanks for the PR, I think though it will no longer be required (same for QuantConnect/pythonnet#48) when we merge in new QC/pythonNet, see QuantConnect/pythonnet#47 & https://github.com/QuantConnect/Lean/tree/PythonNet-Testing @C-SELLERS can confirm

@jaredbroad
Copy link
Member

Thank you for the thoughtful PR @aarjaneiro but we're migrating to pythonnet 2.0 with .NET core support which actually only has 1 binary for all operating systems! Finally! 🎉 We're in the final stages of getting him ready and speed testing it and this won't be needed.

@jaredbroad jaredbroad closed this Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants