Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling Career Choice #1

Open
oyamad opened this issue Jun 30, 2017 · 4 comments
Open

Modeling Career Choice #1

oyamad opened this issue Jun 30, 2017 · 4 comments

Comments

@oyamad
Copy link
Member

oyamad commented Jun 30, 2017

  1. The outcome of career/career_vf_plot.py does not look nice like the figure in the lecture.

  2. In the solution to Exercise 1:

    • max_iter=200 should be added to compute_fixed_point.
    • The line theta_path, epsilon_path = gen_path() should be placed inside the for ax in axes loop.
  3. In the solution to Exercise 2, for the case of beta=0.99:

    • The median should be about 14, rather than 11 as stated.
    • If one wants to avoid getting a RuntimeWarning from non convergence, max_iter should be set, for example, to 1000 (if the default tolerance is used).
@jstac
Copy link

jstac commented Jun 30, 2017

@oyamad Thanks!

@natashawatkins
Copy link
Member

Hi @oyamad, did you want to add max_iter=1000 in the sentence "To compute the median with β=0.99β=0.99 instead of the default value β=0.95β=0.95, replace wp = CareerWorkerProblem() with wp = CareerWorkerProblem(beta=0.99)" ?

@GusHebblewhite
Copy link

It seems like the relevant sentence has been added, although CareerWorkerProblem() cannot take a max_iter argument. I'll fix this now.

@GusHebblewhite
Copy link

GusHebblewhite commented Nov 24, 2017

Fixed here:
https://github.com/jstac/QuantEcon.lectures/pull/834

I think this issue is ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants