From f1e77179a175b57dd91912d95b68b9cb42aec78c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francesc=20Mart=C3=AD=20Escofet?= Date: Wed, 3 Jul 2024 15:44:53 +0200 Subject: [PATCH] Remove skip as fixed --- tests/test_tlearner.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/test_tlearner.py b/tests/test_tlearner.py index 2bfd8c2..8aa0e14 100644 --- a/tests/test_tlearner.py +++ b/tests/test_tlearner.py @@ -11,7 +11,6 @@ from onnxmltools import convert_lightgbm, convert_xgboost from skl2onnx.common.data_types import FloatTensorType from skl2onnx.convert import convert_sklearn -from sklearn.discriminant_analysis import QuadraticDiscriminantAnalysis from sklearn.ensemble import ( HistGradientBoostingClassifier, HistGradientBoostingRegressor, @@ -57,10 +56,6 @@ ), ) def test_tlearner_onnx(nuisance_model_factory, onnx_converter, is_classification, rng): - if nuisance_model_factory == QuadraticDiscriminantAnalysis: - # TODO: investigate the cause why the assertion fails - pytest.skip() - supports_categoricals = nuisance_model_factory in [ LGBMClassifier, LGBMRegressor,