From 60b7653bef875fd21d927951f9dc1a44bb73fbd3 Mon Sep 17 00:00:00 2001 From: kklein Date: Sun, 4 Aug 2024 19:42:09 +0200 Subject: [PATCH 1/4] Adapt CI trigger to run on PR from fork. --- .github/workflows/ci.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f9d98ef0..da118ecd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,16 @@ name: CI -on: [push] +on: + # We would like to trigger for CI for any pull request action - + # both from QuantCo's branches as well as forks. + pull_request: + types: [opened, labeled, unlabeled, synchronize] + # In addition to pull requests, we want to run CI for pushes + # to the main branch and tags. + push: + branches: + - "main" + tags: + - "v*" # Automatically stop old builds on the same branch/PR concurrency: From 1e9b6860dfa177acdb4813319673c876a139af9f Mon Sep 17 00:00:00 2001 From: kklein Date: Sun, 4 Aug 2024 19:48:44 +0200 Subject: [PATCH 2/4] Trigger on any tag, not only those prefixed with v. --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da118ecd..79438770 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,6 @@ on: branches: - "main" tags: - - "v*" # Automatically stop old builds on the same branch/PR concurrency: From 03acefcd0c0830d1700a902eac56464c8dbf394a Mon Sep 17 00:00:00 2001 From: kklein Date: Sun, 4 Aug 2024 19:50:19 +0200 Subject: [PATCH 3/4] Fix syntax. --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 79438770..a94bd959 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,7 @@ on: branches: - "main" tags: + - "*" # Automatically stop old builds on the same branch/PR concurrency: From 13d61eebb7e52af1270c111456e777e5805ed882 Mon Sep 17 00:00:00 2001 From: kklein Date: Sun, 4 Aug 2024 23:33:16 +0200 Subject: [PATCH 4/4] Use default pull request types. --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a94bd959..f455d9e9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,6 @@ on: # We would like to trigger for CI for any pull request action - # both from QuantCo's branches as well as forks. pull_request: - types: [opened, labeled, unlabeled, synchronize] # In addition to pull requests, we want to run CI for pushes # to the main branch and tags. push: