-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockTensorMap #199
BlockTensorMap #199
Conversation
…irectly from a local operator
…iteMPOHamiltonian`
I'm sorry, there's not really a shortcut here. This is a rather large software project, and if you want to understand the full stack, there's not a lot better to do than just reading through One thing that might be useful is that while there are quite a lot of changes, many of these are inconsequential: some slight syntax changes and conventions. Just scrolling through the changes in this PR, you can gloss over these and mark them as "unchanged for all intents and purposes". |
Thanks, that exactly what I was after :) Do you want me to mark things that I find unclear ? |
It depends a bit, if it's user-side things that are unclear, yes. If it's implementation-side things, maybe, but probably not. While I value clarity and readability, I don't have the time to make sure the implementations are always as clear as possible, since MPSKit is not really meant to be educational... |
Unless there are strong opinions against this, I will merge this tomorrow, and keep track of the todos before release in the discussions. The idea is that this PR is a monster, and it's hard to keep an overview of what's going on. There are a few concrete things left to do, which will be easier to track in separate PRs. |
This PR contains a (rather large) amount of breaking changes, by factoring out a large amount of code into a separate package. In particular, we now rely on
BlockTensorKit
to deal with the logic of (sparse) block MPO tensors and environments, which simplifies the code here quite a bit.Additionally, many parts of the code have been cleaned up and renamed, so this change should be considered very breaking.
TODO