Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update normalization convention environments #201

Merged
merged 2 commits into from
Dec 8, 2024
Merged

update normalization convention environments #201

merged 2 commits into from
Dec 8, 2024

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Dec 8, 2024

This changes the normalization convention of the environments to no longer "divide the norm" between left and right, but simply absorb it on the left side. This ensures better compatibility with real states/operators.

Closes #198 .

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/environments/permpoinfenv.jl 89.79% <100.00%> (-0.11%) ⬇️

@lkdvos lkdvos merged commit f1f8b2e into master Dec 8, 2024
6 of 8 checks passed
@lkdvos lkdvos deleted the real-envs branch December 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VUMPS for real-valued iMPS
1 participant