Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Ensure that projection environments have correct above #204

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Dec 11, 2024

This fixes an issue where the environments for projection operators did not get the correct state in their above field, hence giving space mismatches and (likely) wrong results before.

Closes #203

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/environments/FinEnv.jl 97.22% <100.00%> (ø)

... and 2 files with indirect coverage changes

@lkdvos lkdvos merged commit c20d382 into master Dec 11, 2024
27 of 28 checks passed
@lkdvos lkdvos deleted the issue203 branch December 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FiniteExcited() throws SpaceMismatch() error
1 participant