qubes-global-config crashes when a qube gets removed during the tool startup

[marmarek]

Qubes OS release

Qubes OS 4.3, Qubes OS 4.2

Brief summary

When a qube is removed while qubes-global-config is starting up, it crashes. This can happen for example when a disposable qube is closed.

Steps to reproduce

1. Start qubes-global-config
2. While it's still starting, close a disposable qube (depending on timing, doing the two steps in the opposite order may be easier)
3. Wait for qubes-global-config to start

Expected behavior

It starts normally

Actual behavior

It crashes:

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/qubes_config/global_config/global_config.py", line 295, in do_activate
    self.perform_setup()
    ~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/qubes_config/global_config/global_config.py", line 434, in perform_setup
    self.handlers["updates"] = UpdatesHandler(
                               ~~~~~~~~~~~~~~^
        qapp=self.qapp,
        ^^^^^^^^^^^^^^^
        policy_manager=self.policy_manager,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        gtk_builder=self.builder,
        ^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/python3.13/site-packages/qubes_config/global_config/updates_handler.py", line 694, in __init__
    self.update_proxy = UpdateProxy(
                        ~~~~~~~~~~~^
        gtk_builder=gtk_builder,
        ^^^^^^^^^^^^^^^^^^^^^^^^
    ...<3 lines>...
        service_name=self.service_name,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/python3.13/site-packages/qubes_config/global_config/updates_handler.py", line 404, in __init__
    self.has_whonix = self._check_for_whonix()
                      ~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/qubes_config/global_config/updates_handler.py", line 460, in _check_for_whonix
    if "whonix-updatevm" in vm.tags or "anon-gateway" in vm.tags:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/qubesadmin/tags.py", line 65, in __contains__
    response = self.vm.qubesd_call(self.vm.name, 'admin.vm.tag.Get', elem)
  File "/usr/lib/python3.13/site-packages/qubesadmin/base.py", line 76, in qubesd_call
    return self.app.qubesd_call(dest, method, arg, payload,
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        payload_stream)
        ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/qubesadmin/app.py", line 786, in qubesd_call
    return self._parse_qubesd_response(return_data)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/qubesadmin/base.py", line 111, in _parse_qubesd_response
    raise exc_class(format_string, *args)
qubesadmin.exc.QubesVMNotFoundError: No such domain: 'disp1342'
2025-02-21 15:17:47,644 icon-receiver: disconnected: disp1342

Additional information

https://openqa.qubes-os.org/tests/129579