Fix match query for integer fields
#1037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `match` query is in most cases a full-text search, e.g.:
```json
{
"query": {
"match": {
"message": "this is a test"
}
}
}
```
However, it can also be used to find an exact value against a integer
field:
```json
{
"query": {
"match": {
"products_count": "5"
}
}
}
```
In such case Quesma would generate an invalid SQL, trying to do an
`ILIKE` against an `Int64` column:
```
Illegal type Int64 of argument of function ilike
```
Fix the issue by introducing an internal __quesma_match operator and
a transformation which transforms it either to `ILIKE` or `=`.
Fixes QuesmaOrg#1018
nablaone
reviewed
Nov 25, 2024
quesma/quesma/schema_transformer.go
Outdated
| } | ||
| switch field.Type.String() { | ||
| case schema.QuesmaTypeInteger.Name, schema.QuesmaTypeLong.Name, schema.QuesmaTypeUnsignedLong.Name: | ||
| return model.NewInfixExpr(lhs, "=", model.NewLiteral(rhs.Value.(string))) |
There was a problem hiding this comment.
What about other data types? data, float?
There was a problem hiding this comment.
The Elastic's documentation doesn't specify this behavior (and the code itself is convoluted), but empirically testing with Elastic:
- float: doesn't work (tried
AvgTicketPrice:123.12filter) - boolean: works, therefore added it to switch
- date:
date_field:[DATE_VALUE]doesn't work; you can click to filter by it in Kibana, but then it emits different filter thanmatch - keyword:
keyword_field:[KEYWORD_VALUE]emits a different filter thanmatch
I did not test other types. Therefore, I think it's OK for us to support only those types mentioned in switch right now.
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matchquery is in most cases a full-text search, e.g.:{ "query": { "match": { "message": "this is a test" } } }However, it can also be used to find an exact value against a integer field:
{ "query": { "match": { "products_count": "5" } } }In such case Quesma would generate an invalid SQL, trying to do an
ILIKEagainst anInt64column:Fix the issue by introducing an internal __quesma_match operator and a transformation which transforms it either to
ILIKEor=.Fixes #1018