fix: Do not remove Cache-Control end user defined header value

QwikDev · Nov 5, 2024 · ffee7e3 · ffee7e3
1 parent f72fda5
commit ffee7e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.changeset/moaning-master-chief.md b/.changeset/moaning-master-chief.md
@@ -0,0 +1,5 @@
+---
+'@builder.io/qwik-city': patch
+---
+
+fix: Redirect, error, and fail request events no longer forcefully delete user-defined Cache-Control HTTP header value.
diff --git a/packages/qwik-city/src/middleware/request-handler/request-event.ts b/packages/qwik-city/src/middleware/request-handler/request-event.ts
@@ -194,7 +194,6 @@ export function createRequestEvent(
 
     error: (statusCode: number, message: string) => {
       status = statusCode;
-      headers.delete('Cache-Control');
       return new ErrorResponse(statusCode, message);
     },
 
@@ -208,10 +207,6 @@ export function createRequestEvent(
         }
         headers.set('Location', fixedURL);
       }
-      headers.delete('Cache-Control');
-      if (statusCode > 301) {
-        headers.set('Cache-Control', 'no-store');
-      }
       exit();
       return new RedirectMessage();
     },
@@ -223,7 +218,6 @@ export function createRequestEvent(
     fail: <T extends Record<string, any>>(statusCode: number, data: T): FailReturn<T> => {
       check();
       status = statusCode;
-      headers.delete('Cache-Control');
       return {
         failed: true,
         ...data,