Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] QwikLoader missing in Storybook #5157

Closed
O-Hooman opened this issue Sep 13, 2023 · 4 comments
Closed

[🐞] QwikLoader missing in Storybook #5157

O-Hooman opened this issue Sep 13, 2023 · 4 comments
Labels
COMP: docs Improvements or additions to documentation TYPE: bug Something isn't working

Comments

@O-Hooman
Copy link

O-Hooman commented Sep 13, 2023

Which component is affected?

Qwik Runtime

Describe the bug

it seems useVisibleTask$ not working (the code inside is not executed) but useTask$ is working

Reproduction

https://stackblitz.com/edit/qwik-starter-4bzif2

Steps to reproduce

pnpm install && pnpm dev

System Info

System:
    OS: macOS 13.0
    CPU: (8) arm64 Apple M1
    Memory: 38.41 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
    pnpm: 8.6.3 - ~/.nvm/versions/node/v16.17.0/bin/pnpm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.1
  npmPackages:
    @builder.io/dev-tools: ^0.1.10 => 0.1.10 
    @builder.io/qwik: ^1.2.10 => 1.2.10 
    @builder.io/qwik-city: ^1.2.10 => 1.2.10 
    @builder.io/sdk-qwik: ^0.5.9 => 0.5.9 
    undici: 5.22.1 => 5.22.1 
    vite: 4.3.9 => 4.3.9

Additional Information

qwik v1.1.5 works but v1.2.x does not work

  • What should I see?
    console log of text "inside task" and "inside visible task"
  • What do I click on?
    button > Primary on storybook
  • What you expect to happen?
    console log "inside visible task" executed by useVisibleTask$
  • What is happening instead?
    console log "inside visible task" not executed (didn't show at console)
@O-Hooman O-Hooman added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels Sep 13, 2023
@mhevery
Copy link
Contributor

mhevery commented Sep 13, 2023

can you provide repro instructions?

  • What should I see
  • What do I click on
  • What you expect to happen
  • What is happening instead?

@O-Hooman
Copy link
Author

O-Hooman commented Sep 13, 2023

can you provide repro instructions?

  • What should I see
  • What do I click on
  • What you expect to happen
  • What is happening instead?

ah sorry i forgot about it

  • console log of text "inside task" and "inside visible task"
  • button > Primary on storybook
  • console log "inside visible task" executed by useVisibleTask$
  • console log "inside visible task" not executed (didn't show at console)

@mhevery
Copy link
Contributor

mhevery commented Sep 15, 2023

The application does not work because there is no <script id="qwikloader">...</script> on the page. I am not an expert of how this was integrated with storybook, but I am pretty sure that adding that will fix the codebase.

Once fixed it would be great to update the instructions https://qwik.builder.io/docs/integrations/storybook/ for others.

@PatrickJS PatrickJS changed the title [🐞] useVisibleTask$ not working on storybook [🐞] QwikLoader missing in Storybook May 7, 2024
@shairez shairez added COMP: docs Improvements or additions to documentation and removed STATUS-1: needs triage New issue which needs to be triaged labels May 25, 2024
@shairez
Copy link
Contributor

shairez commented May 25, 2024

seems like this is fixed via literalpie/storybook-framework-qwik#68

closing

@shairez shairez closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation TYPE: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants