Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Update the Qwik Library starter #5559

Open
shairez opened this issue Dec 11, 2023 · 2 comments
Open

[✨] Update the Qwik Library starter #5559

shairez opened this issue Dec 11, 2023 · 2 comments
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request

Comments

@shairez
Copy link
Contributor

shairez commented Dec 11, 2023

Is your feature request related to a problem?

Following up on #5097

Describe the solution you'd like

We need to update the starter vite.config.ts and add

dts({
	// ...
	entryRoot: 'src'
})

and also

build: {  
  // ...
  rollupOptions: {
    output: {
        preserveModules: true,
        preserveModulesRoot: 'packages/kit-headless/src',
      },
  }
}  

Describe alternatives you've considered

not relevant

Additional context

I think we should implement this fix only after we fix #5473

@maiieul
Copy link
Contributor

maiieul commented Dec 11, 2023

I agree, we should wait until #5473 is fixed before doing this. I'd currently rather have the "big" bundle rather than the namespace issues preserveModules creates.

@gioboa
Copy link
Member

gioboa commented Oct 14, 2024

Is it still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants