Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] v2: v1 compat JSXNode types #7041

Closed
wmertens opened this issue Nov 4, 2024 · 0 comments
Closed

[🐞] v2: v1 compat JSXNode types #7041

wmertens opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
COMP: DX Developer Experience related issue TYPE: bug Something isn't working VERSION: upcoming major

Comments

@wmertens
Copy link
Member

wmertens commented Nov 4, 2024

Which component is affected?

Qwik Runtime

Describe the bug

When building v2 with v1 libs, the types don't match up for JSXNode.

Both v1 and v2 expose JSXNode types that include internal properties:

  • v1 exposes immutableProps
  • v2 exposes varProps and constProps

While v2 correctly handles v1 imports during transformation, typescript still refers to v1 for types

Reproduction

https://github.com/thejackshelton-kunaico/v2-empty

Steps to reproduce

pnpm i and pnpm exec tsc

System Info

latest

Additional Information


Proposed fix: either:

  • change v1 and v2 types so they don't expose the internal names. Rename to $varProps$ etc? This means quite a lot of code changes
  • create @builder.io packages that claim to be v2 and that add a peerDep to their @qwik.dev counterparts and re-export them.
@wmertens wmertens added TYPE: bug Something isn't working COMP: DX Developer Experience related issue VERSION: upcoming major labels Nov 4, 2024
@wmertens wmertens moved this from Backlog to Upcoming in Qwik Development Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Qwik Development Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: DX Developer Experience related issue TYPE: bug Something isn't working VERSION: upcoming major
Projects
Archived in project
Development

No branches or pull requests

1 participant