-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: added ability to publish test packages #6389
Conversation
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying qwik-docs with Cloudflare Pages
|
.github/workflows/ci.yml
Outdated
@@ -481,6 +494,9 @@ jobs: | |||
packages/qwik-labs/vite/ | |||
packages/qwik-labs/package.json | |||
if-no-files-found: error | |||
- run: pnpx pkg-pr-new publish --compact ./packages/qwik/dist ./packages/qwik-city/dist dist-dev-eslint-plugin-qwik dist-dev-create-qwik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes these dist-dev directories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the upload-artifacts task from the job before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I really like this idea.
Currently |
@shairez we can fix the size limit by not shipping the native plugins, only the wasm. For that, it should skip the native builds and you should overwrite |
Run & review this pull request in StackBlitz Codeflow. @builder.io/qwik (
|
Thank you so much team! |
- name: Publish packages for testing | ||
run: pnpm dlx [email protected] publish --compact --pnpm ./packages/qwik/dist ./packages/qwik-city/lib ./packages/eslint-plugin-qwik/dist ./packages/create-qwik/dist | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed anymore, FYI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the github token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep!
Thanks so much @Aslemammad for the awesome job you did in creating this and fixing it to make it work for us as well |
🙌🙌🙌 |
Overview
What is it?
Description
Added pkg.pr.new to be able to test PRs and latest main commits without the need to release a new version each time.
Great for testing new fixes before they go live
Checklist: