Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed release from main to upcoming branch #7064

Merged
merged 1 commit into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"fixed": [["@builder.io/qwik", "@builder.io/qwik-city", "eslint-plugin-qwik", "create-qwik"]],
"linked": [],
"access": "public",
"baseBranch": "main",
"baseBranch": "upcoming",
"updateInternalDependencies": "minor",
"ignore": [
"qwik-docs",
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
push:
branches:
- main
- upcoming
- next
- qwik-labs
- vercelserverless
Expand Down Expand Up @@ -76,7 +77,7 @@ jobs:
- name: Set Dist Tag
id: set_dist_tag
if: |
github.ref == 'refs/heads/main' && (
github.ref == 'refs/heads/upcoming' && (
github.event_name == 'push' ||
github.event_name == 'workflow_dispatch'
)
Expand Down Expand Up @@ -811,12 +812,12 @@ jobs:
- test-unit
- test-e2e
# test-unit runs when any packages changes, so we have to release
# on main, we always check if we have something to release
# on "upcoming", we always check if we have something to release
# don't run on forks
if: |
always() &&
github.repository == 'QwikDev/qwik' && (
github.ref == 'refs/heads/main' ||
github.ref == 'refs/heads/upcoming' ||
needs.test-unit.result == 'success'
)

Expand Down Expand Up @@ -870,7 +871,7 @@ jobs:
# Do this before other release steps to avoid
# publishing temporary files
- name: Create Release Pull Request or Publish to npm
if: github.ref == 'refs/heads/main'
if: github.ref == 'refs/heads/upcoming'
id: changesets
uses: changesets/action@v1
with:
Expand Down Expand Up @@ -899,7 +900,7 @@ jobs:
trigger-qwikcity-e2e:
name: Trigger Qwik City E2E
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
if: github.ref == 'refs/heads/upcoming'

needs:
- changes
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ If you're interested in helping out with triaging issues, please follow the [Tri

### Branch Organization

We adopt [trunk-based development](https://trunkbaseddevelopment.com/) therefore all Pull Requests are made against the main branch because we do not use separate branches for development or for the versions we release.
We adopt [trunk-based development](https://trunkbaseddevelopment.com/) therefore all Pull Requests are made against the main branch.
Before releasing, we merge `main` into a release branch, for testing purposes.

### Good first issue

Expand Down Expand Up @@ -366,7 +367,7 @@ For your convenience, we prepared a video tutorial that covers the process of ad
Make sure the PR follows all the guidelines in this document. Once you think the PR is good to merge, if the commits are "nice", you can merge the PR. If not, squash the PR.

In case the PR is stuck waiting for the original author to apply a trivial
change (a typo, capitalisation change, etc.) and the author allowed the members
change (a typo, capitalization change, etc.) and the author allowed the members
to modify the PR, consider applying it yourself (or commit the existing review
suggestion). You should pay extra attention to make sure the addition doesn't go
against the idea of the original PR and would not be opposed by the author.
Expand Down