Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Musly to Hanyuu #89

Open
4 tasks
Bevinsky opened this issue Apr 26, 2017 · 2 comments
Open
4 tasks

Adding Musly to Hanyuu #89

Bevinsky opened this issue Apr 26, 2017 · 2 comments

Comments

@Bevinsky
Copy link
Contributor

Bevinsky commented Apr 26, 2017

We want Hanyuu to pick similar songs when queuing up randoms into the queue. The best option is probably Musly. This needs a couple components and changes:

  • Service/daemon to manage the Musly collection database
    This service will interface with libmusly to store and manage the Musly jukebox. It needs remote calls (via some protocol) to add tracks to the collection, remove tracks from the collection, and fetch a list of tracks similar to a given one. Possibly other things as well.
  • Changes to the verifier
    Whenever the verifier verifies a song, it needs to call the Musly service and tell it to index the track that was just verified (or update the index in case it's a reverification/reupload).
  • Changes to the queue daemon
    The queue daemon must query the Musly service when it wants to add random tracks to the bottom of the queue. The idea I have in mind is that it will pull the bottommost track and ask the Musly service for similar tracks. Then it will pick the most similar track which has not been played within some threshold of time (and is not already in the queue) and add it to the queue.
  • Changes to the site
    When removing songs in the admin panel, the Musly service must be notified to remove it from the collection. This means the service interface should probably be something curlable, as this is relatively easy in PHP (it already does something similar with Hanyuu for requests).
@KilimIG
Copy link

KilimIG commented Apr 26, 2017

=====
FEATURE REQUEST

is there/can there be a way to 'hide' songs from the musly database? this applies strictly to songs that are taken into account for the random queue, users can still request said songs on their own. (the staff could unanimously decide on certain songs being just terrible and request-able only)

also, restricting a certain tag/genre to 'x' plays. for example. you don't want to have more than 3 vocaloid tracks play in sequence at a time (because its trash) so can we limit the amount of sequential plays-by-tags on a per tag basis

@ghost
Copy link

ghost commented May 7, 2017

Sounds pretty cool, and I might have the time and experience to be able to help on this one over the coming weeks, keep me posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants