Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update metadata better #14

Open
resttime opened this issue Feb 2, 2019 · 1 comment
Open

update metadata better #14

resttime opened this issue Feb 2, 2019 · 1 comment
Labels
1.3 version

Comments

@resttime
Copy link
Contributor

resttime commented Feb 2, 2019

Process API immediately if a song is finished for quicker metadata updates. Or better yet make a custom class for ExoPlayer to retrieve and parse the ICY headers
@resttime resttime added the 1.3 version label Feb 2, 2019
@j-levy
Copy link
Contributor

j-levy commented Sep 27, 2019 •
edited
Loading

I started to look into the issue on my fork.
I noticed that the latest version of ExoPlayer 2.10 has metadata parsing for SHOUTcast streams, so that's just what the app needs. To run it, I updated all the app dependencies to androidx (SDK 28) since ExoPlayer needs it. All the libraries are renamed and a few tweaks here and there had to be implemented for the app to run correctly on Android 9+ (in particular compilation options using Java 8 and permission in the manifest). The app still runs on API 16+ (Android 4.1 and up), but the feature for better metadata parsing has not been implemented yet. Still, I think it's good to have a code base updated to the latest standard. See Pull Request #23 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.3 version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@resttime @j-levy