Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song player for admin page stutters and fails #37

Open
Bevinsky opened this issue Mar 11, 2014 · 0 comments
Open

Song player for admin page stutters and fails #37

Bevinsky opened this issue Mar 11, 2014 · 0 comments

Comments

@Bevinsky
Copy link
Contributor

The player on the database and pending songs pages is not really very good; it stutters (yes due to UI thread blah blah), occasionally fails to play songs, and has issues with seeking. The old player, based on jPlayer never had these issues.

I suggest that the player is set up as following: If it's FLAC, use flac.js. Otherwise, use jPlayer. There's really no need to use a spotty JS implementation of MP3 decoding when browsers (and flash (suck a duck)) can handle it perfectly well.

This setup should only result in messy code if proper generalizations are not made. All you need is a generic interface for starting, stopping, loading and unified callbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant