Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: unprivileged user accounts #87

Open
icxes opened this issue Feb 19, 2024 · 1 comment
Open

feature: unprivileged user accounts #87

icxes opened this issue Feb 19, 2024 · 1 comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature post-1.0 issue won't be resolved until after launch

Comments

@icxes
Copy link
Collaborator

icxes commented Feb 19, 2024

I've brought this up before, but I think we ssie should seriously consider adding unprivileged/normal user accounts. The way I see it, at least

  1. submitting songs, and possibly
  2. commenting on news (to avoid this, or at least make it easier to deal with)

should be limited to logged in users. There should also be some way to connect a website user to an IRC nick (a field you can set in profile? a code you need to PM Hanyuu?). I wouldn't keep basic functionality like listening, requesting, searching, etc. behind registration, though.

Pros:

  • Could associate good uploads with a particular user (the current "Good?" button supposedly does this with IPs, but IPs change, unlike users, which is why nobody currently uses it)
  • Users could favorite songs directly on the website (provided they've "linked" their website account and irc nick)
  • Possibility of sending some form of (optional/opt-in) notifications (email? notification on the site?) about things (song submission accepted? new news post? etc.) if we ever decide that's a feature worth having

Cons:

  • Extra complexity. Probably requires extensive rework of the code, since currently any user is assumed to be at least somewhat "trusted".

Other:

I would expect this to be one of the first feature requests if anyone was to actually ever use valkyrie outside of r/a/dio. Which could actually happen, since there was already more than one person asking about that with the old site... until they realised they'd never be able to set it up.

@icxes icxes added the feature-request issue is suggesting a new feature or a change to an existing feature label Feb 19, 2024
@Wessie
Copy link
Contributor

Wessie commented Feb 20, 2024

Personally don't think we should require user accounts for anything in particular, the issue with news can be avoided by closing comments after a while and just having easier to use management tools. Optional accounts could still be considered but would probably be a post-1.0 thing

@Wessie Wessie added the post-1.0 issue won't be resolved until after launch label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature post-1.0 issue won't be resolved until after launch
Projects
None yet
Development

No branches or pull requests

2 participants